Conversation
Contributor
WalkthroughThe recent change involves a significant revision to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
skip-changelog
sharat87
added
ok-to-test
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- app/client/cypress/fixtures/emptyDSL.json (1 hunks)
Files skipped from review due to trivial changes (1)
- app/client/cypress/fixtures/emptyDSL.json
mohanarpit
approved these changes
Jun 26, 2024
Shivam-z
pushed a commit
to Shivam-z/appsmith
that referenced
this pull request
Jul 10, 2024
Part of appsmithorg#33724, and extension to appsmithorg#34405. This file's contents are used to call the endpoint: ``` /layouts/{layoutId}/pages/{pageId}?applicationId={applicationId} ``` But this endpoint accepts request payload as `LayoutUpdateDTO`, which only has one single field, `dsl`, and nothing else. But the way we use this JSON, is that we're sending the body as this: ```json { "widgetName": "MainContainer", "backgroundColor": "none", "rightColumn": 1296, "snapColumns": 64, "detachFromLayout": true, "widgetId": "0", "topRow": 0, "bottomRow": 440, "containerStyle": "none", "snapRows": 125, "parentRowSpace": 1, "type": "CANVAS_WIDGET", "canExtend": true, "version": 47, "minHeight": 420, "parentColumnSpace": 1, "dynamicBindingPathList": [], "leftColumn": 0, "children": [] } ``` Not as this: ```json { "dsl": { "widgetName": "MainContainer", "backgroundColor": "none", "rightColumn": 1296, "snapColumns": 64, "detachFromLayout": true, "widgetId": "0", "topRow": 0, "bottomRow": 440, "containerStyle": "none", "snapRows": 125, "parentRowSpace": 1, "type": "CANVAS_WIDGET", "canExtend": true, "version": 47, "minHeight": 420, "parentColumnSpace": 1, "dynamicBindingPathList": [], "leftColumn": 0, "children": [] } } ``` Which means that we aren't sending anything useful. /test widget ide <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9680215500> > Commit: 8ede3e7 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9680215500&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Widget, @tag.IDE` <!-- end of auto-generated comment: Cypress test results -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #33724, and extension to #34405.
This file's contents are used to call the endpoint:
But this endpoint accepts request payload as
LayoutUpdateDTO, which only has one single field,dsl, and nothing else.But the way we use this JSON, is that we're sending the body as this:
{ "widgetName": "MainContainer", "backgroundColor": "none", "rightColumn": 1296, "snapColumns": 64, "detachFromLayout": true, "widgetId": "0", "topRow": 0, "bottomRow": 440, "containerStyle": "none", "snapRows": 125, "parentRowSpace": 1, "type": "CANVAS_WIDGET", "canExtend": true, "version": 47, "minHeight": 420, "parentColumnSpace": 1, "dynamicBindingPathList": [], "leftColumn": 0, "children": [] }Not as this:
{ "dsl": { "widgetName": "MainContainer", "backgroundColor": "none", "rightColumn": 1296, "snapColumns": 64, "detachFromLayout": true, "widgetId": "0", "topRow": 0, "bottomRow": 440, "containerStyle": "none", "snapRows": 125, "parentRowSpace": 1, "type": "CANVAS_WIDGET", "canExtend": true, "version": 47, "minHeight": 420, "parentColumnSpace": 1, "dynamicBindingPathList": [], "leftColumn": 0, "children": [] } }Which means that we aren't sending anything useful.
/test widget ide
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9680215500
Commit: 8ede3e7
Cypress dashboard.
Tags:
@tag.Widget, @tag.IDESummary by CodeRabbit